celestia-core icon indicating copy to clipboard operation
celestia-core copied to clipboard

Don't assume that all transaction reaped from the mempool will be accepted by the application

Open evan-forbes opened this issue 2 years ago • 2 comments

Currently, tendermint will reap transactions on the mempool based on the MaxBytes consensus param because it assumes that all the transactions that are reaped will make it in the block. Since this assumption is not true, we should instead reap more than MaxBytes and rely on the application to create proposals that are small enough.

edit: per discussion below this issue is blocked by #1241 1241

evan-forbes avatar May 12 '23 01:05 evan-forbes

first before we move forward with a solution to this issue we should gather more data on roughly how large of a problem this is. We first need a metric determining how efficient this process is

evan-forbes avatar Sep 01 '23 11:09 evan-forbes

We could track as a metric how many transactions are rejected by the application

cmwaters avatar Feb 21 '24 09:02 cmwaters