Callum Waters
Callum Waters
> Is this PR really needed on past branches? v0.37 isn't exactly a past branch. Perhaps we can still add it there but drop the backport to v0.34?
**This is set for v0.37.1 (i.e. do not merge until after v0.37.0)**
I have some general comments that can possible be followed up at a later point: - Can we break up data structures into smaller more self-explanatory files so that parts...
> there will need to be a store migration to migrate the existing version to consensus params This is a migration of the upgrade module right? So it would read...
Does that mean I need to bump the consensus version from 2 to 3?
I've come across something of a deadlock here. We don't set state and the consensus params until `InitChain` which makes sense as CometBFT is providing the consensus params (which contain...
Do we want to assert that the height in the plan in [`ApplyUpgrade`](https://github.com/cosmos/cosmos-sdk/blob/b1fd8cf26173040a5f621a76e53efa81a126f3f0/x/upgrade/keeper/keeper.go#L458) matches the block height in the context. I'm seeing a test fail because these two values are...
> Do we want to assert that the height in the plan in [`ApplyUpgrade`](https://github.com/cosmos/cosmos-sdk/blob/b1fd8cf26173040a5f621a76e53efa81a126f3f0/x/upgrade/keeper/keeper.go#L458) matches the block height in the context. I'm seeing a test fail because these two values...
> would you be willing to update the docs if needed? In the upgrade module? Or are there other places that require documentation