Results 37 comments of Colin Patrick McCabe

Jenkins went down again. :( ``` java.nio.file.FileSystemException: /home/jenkins/workspace/Kafka_kafka-pr_PR-12636: No space left on device ```

I uploaded a new version at https://github.com/apache/kafka/pull/12662

Does the connector call recoverLease?

It is part of the KRaft Authorizer KIP, but slipped from 3.2 [ edit: link is https://cwiki.apache.org/confluence/display/KAFKA/KIP-801%3A+Implement+an+Authorizer+that+stores+metadata+in+__cluster_metadata ]

Thanks for finding this, @dengziming . It is a great find and definitely a 3.3 blocker.

So, the reason we didn't notice this bug earlier is that it doesn't affect single-node clusters. And in the multi-node ducktape test that I wrote, the upgrade command was failing...

This does look right to me but let me check with @mumrah . Thanks, @blcksrx

I'm going to leave a -1 here because there are a number of issues in the patch and it's not ready to commit yet. I would encourage you to split...

> @Hangleton : Agree that this change should be ideally confined to the Windows platform w/o any code change for others. Yeah. To be totally clear, it's OK to change...

Hi spetsnaz84, I think it would be relatively easy to treat semaphores similar to how I treat mutexes currently. The main difference is that semaphores can be released from threads...