kafka
kafka copied to clipboard
KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
This issue happens cause the cluster.startup() invoked already and the solution is just check the clusterConfig.isAutoStart in the BeforeTestExecutionCallback.
In addition I believe checking just a broker state is not sufficient and it's better to invoke cluster.waitForReadyBrokers() instead but I didn't change it, cause it was out of scope of the issue.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Thank you for this PR @blcksrx , the change looks reasonable, for my understanding, what is the motivation for this change? did you find the AutoStart is useful while working on additional tests?
@dengziming In situations, such as different configs for brokers, this AutoStart is helpful. As an example, I believe this ticket needs flexibility KAFKA-12617 of AutoStart.No
This does look right to me but let me check with @mumrah . Thanks, @blcksrx
Just checking what is the status of this PR