kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-13648: KRaft ClusterInstance does not allow for deferred start

Open blcksrx opened this issue 3 years ago • 3 comments

This issue happens cause the cluster.startup() invoked already and the solution is just check the clusterConfig.isAutoStart in the BeforeTestExecutionCallback.

In addition I believe checking just a broker state is not sufficient and it's better to invoke cluster.waitForReadyBrokers() instead but I didn't change it, cause it was out of scope of the issue.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

blcksrx avatar Jul 11 '22 15:07 blcksrx

Thank you for this PR @blcksrx , the change looks reasonable, for my understanding, what is the motivation for this change? did you find the AutoStart is useful while working on additional tests?

dengziming avatar Jul 13 '22 11:07 dengziming

@dengziming In situations, such as different configs for brokers, this AutoStart is helpful. As an example, I believe this ticket needs flexibility KAFKA-12617 of AutoStart.No

blcksrx avatar Jul 13 '22 11:07 blcksrx

This does look right to me but let me check with @mumrah . Thanks, @blcksrx

cmccabe avatar Aug 02 '22 22:08 cmccabe

Just checking what is the status of this PR

blcksrx avatar Sep 27 '22 11:09 blcksrx