Colin Patrick McCabe
Colin Patrick McCabe
Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory.
LGTM. It's good that you assigned MiniKDC a defined port as well.
It seems simpler to just pass the ApiVersionsResponse version as a parameter to the Supplier (hence making it a Function, I guess) Updated.
It looks like the test was checking the ApiVersionsRequest header version against 3. So it needed to be updated to 4
The test failures pass locally.
The context here is that we’re adding kraft.version in 3.9. But not in this PR. I did add kraft.version to supportedFeatures, simply so that I could verify that the RPC...
general comment (about all the APIs) is that it feels better to have a separate function to replace the entire metadata map, rather than making it a boolean