Christoph M. Becker comments

Results 597 comments of


                                            Christoph M. Becker

Meaningless caution on generator syntax page since the related example was removed

Oh, https://github.com/php/doc-en/commit/cdaea0421544885f02ff3d36bd203dc01b78299e#diff-9e27d08e700634a0fe443f7249fd2bcbcfc7f5c788e96dcd298843b78010ddbc removed the example to which the note was referring to.

Fix Throwable note to mention that Error can be extended (fixes #1647).

But see https://github.com/php/doc-en/issues/1647#issuecomment-1165439900 f. I'm really unsure whether userland code should extend `Error`.

reset($arrayIterator) returns false

It is already stated for ArrayObject in the [migration guide](https://www.php.net/manual/en/migration74.incompatible.php): > [reset()](https://www.php.net/manual/en/function.reset.php), [current()](https://www.php.net/manual/en/function.current.php), etc. Use [Iterator](https://www.php.net/manual/en/class.iterator.php) methods instead. Probably makes sense to mention ArrayIterator here as well, and there should...

Status of php.net documentation

[`SolrDocument::__construct()`](https://github.com/php/pecl-search_engine-solr/blob/eb58118da1c9d50dcdbda5c17b271b8d07b703ea/src/php7/php_solr_document.c#L473) and [`::__destruct()`](https://github.com/php/pecl-search_engine-solr/blob/eb58118da1c9d50dcdbda5c17b271b8d07b703ea/src/php7/php_solr_document.c#L494) apparently do something, so they should be documented (at least we could add `&warn.undocumented.func;`).

PHP 8.1 Compatibility Fixes

I can confirm that these changes are required for PHP 8.1 compatibility.

Documenting/improving ways to quickly check docbook xml syntax/correctness on editor save

> * I see https://docbook.org/ns/docbook has no official schema. doc-base has RFC/schema for a proposed schema but the commit from 2010 notes "PhD doesn't use any of this" DocBook switch...

Generate int/float/null instead of integer/double/NULL in docgen.php

> Latest example: [php/doc-en@d6aee4a#diff-6193da7441a9b194146a36138e21738e68cf63c7f17cbd4bff4726d431f2093e](https://github.com/php/doc-en/commit/d6aee4a5004f7d532f24c06ea2ab2ac0b91b8664#diff-6193da7441a9b194146a36138e21738e68cf63c7f17cbd4bff4726d431f2093e) This would need changes to https://github.com/php/doc-base/blob/master/scripts/docgen/class.tpl (and generally, we should align these .tpl files and the files in https://github.com/php/doc-base/tree/master/RFC/skeletons).

Let build fail for erroneous xincludes

Hmm, might not be the best approach, considering #80. Let me see.