Christoph M. Becker
Christoph M. Becker
Hmm, [according to the docs](https://www.php.net/die): > This language construct is equivalent to exit(). IMO, there is no need to explicitly mention `die()` here.
Yeah, this PR should be closed. Nonetheless, thanks for working on this, @ShadyMedic!
> but difficult to maintain in the future. Yeah. I wonder whether we should refer to https://github.com/php/php-src/blob/master/ext/mbstring/libmbfl/mbfl/eaw_table.h instead.
Indeed, there is something wrong with the rendering. Possibly only something that would need to be fixed in PhD, but maybe it's something we should fix in the docs. Reopening,...
Indeed, this is a duplicate of php/php-src#8746. > I suggest we may add a note to the doc, like what we do for `BIGINT` PK. ACK.
Indeed, it makes sense to clarify that.
Not a documentation issue, but apparently `fiber.stack_size` is not part of the default php.ini files of php-src.
> 7.2 -> PHP Parse error: syntax error, unexpected ')' This is due to https://wiki.php.net/rfc/trailing-comma-function-calls; only available as of PHP 7.3.0, and apparently not documented. I could only find the...
> I'm not sure what the difference between `simpara` and `para` is, or where to learn more about them. See https://tdg.docbook.org/tdg/4.5/simpara.html vs. https://tdg.docbook.org/tdg/4.5/para.html. TL;DR: we render `` as ``, and...
Yeah, [that code](https://github.com/php/php-src/blob/master/ext/xml/xml.c#L432-L439) could need some TLC.