Christoph M. Becker
Christoph M. Becker
Uh oh – from the [spec](https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT), paragraph 4.4.17.1 : > The name of the file, with optional relative path. The path stored MUST NOT contain a drive or device letter,...
> Well it does seem to be automatically fixing the $entryname under linux (aka removing the leading slash), For me, it does (using current PHP master with libzip 1.5.1). >...
> How about just adding a deprecation notice if the filenames are non spec compliant? For me, a deprecation means that support for something will be removed in a future...
Please run the tests again, but not with PHPUnit, but rather with PHP's test runner (run-tests.php).
There are DLLs available on https://pecl.php.net/package/pcov for a while.
So it seems this ticket can be closed.
> Maybe the installation docs should lead to pecl first? Oh, indeed https://github.com/krakjoe/pcov/blob/develop/INSTALL.md should be fixed.
On Windows, `PHP_VERSION` is already available for config.w32; isn't `$PHP_VERSION` also available for config.m4? @manarth, better open a new ticket about this, since it is unrelated to the issue at...
The patch looks sensible to me. However, `ZEND_COMPILE_EXTENDED_STMT` is only available as of PHP 7.4.0, while pcov is still supposed to support PHP 7.1+. As such either that line would...