Christoph M. Becker

Results 597 comments of Christoph M. Becker

Indeed, spaces in the folder name are not supported, and I don't think it makes much sense to support that, because the base folder name is supposed to have a...

DLLs for PHP 8.2 and 8.3 are available now https://pecl.php.net/package/mailparse/3.1.6/windows. If DLLs will be missing in the future, just file a ticket at https://github.com/php/php-windows-builder.

I suggest to double check this with a good memory leak detector (e.g. valgrind or MSan), using `USE_ZEND_ALLOC=0`; see also https://www.phpinternalsbook.com/php7/memory_management/memory_debugging.html.

Indeed, https://github.com/php/pecl-mail-mailparse/commit/bd4a675032f778d676e1244cd0880c104526b4c9 isn't correct; it causes the memory leaks.

> ```` > #5 0x0000ffff9cc04040 in __GI___assert_fail ( > assertion=0xaaaae14c6ed8 "(str)->val[(str)->len] == '\\0' && \"String is not null-terminated\"", > file=0xaaaae14c6e80 "/home/ubuntu/src/php-src/Zend/zend_variables.c", line=63, > ```` Not good.

See https://github.com/php/php-src/issues/15628.

This issue has been fixed upstream, so I'm closing this ticket.

The relevant difference is the libzip version (1.5.1 on Linux, but 1.7.1 on Windows). [As of libzip 1.6.0, "Do not accept empty files as valid zip archives any longer."](https://libzip.org/news/release-1.6.0.html). I'm...

That's a bug or limitation of the Windows explorer. Checking the file with [7-zip](https://www.7-zip.fr/) shows that the file is there.