Christian Lück
Christian Lück
@frosty00 Good catch! Agree that it should be possible to remove the default `User-Agent: ReactPHP/1` request header with a `withoutHeader('User-Agent')` call. @51imyy Good job with the PR so far! Is...
I agree that supporting the latest ChildProcess component makes perfect sense, but I don't see how this currently supports Windows? Perhaps split this into a separate follow-up PR? For the...
@WyriHaximus That's great! Let's make this actionable, what makes this PR "WIP"?
@WyriHaximus That would be fantastic! See https://github.com/reactphp/child-process/pull/71 for possible Travis CI config.
@gdejong Thanks for reporting! The `get()` method (any many others) do indeed use a `@return PromiseInterface` annotation. This was added a while ago, i.e. before PHPStan/Psalm started supporting the `@template`...
> > > @WyriHaximus Thanks for the update! > > > Can you provide a quick update here, what's your plan for this feature with regards to #425? We've briefly...
I don't have any strong opinions on this one and I'm still not sure what to do about this PR, but I'm currently leaning towards not maintaining this component anymore...
@alexpts Thanks for filing this PR! I'm not a big fan of exposing these classes and using inheritance to override internal behavior, but perhaps I'm missing some context. The motivation...
> Hello @clue , are there anything that can be done to move this PR forward since this is still a desired feature? @bosunski Thank you for the friendly reminder!...
@bosunski Agreed, let's continue the discussion in the feature ticket #376 and close this PR. May I ask you to post a quick gist in that ticket so others can...