Christian Lück
Christian Lück
@Manuelacosta98 Thanks for reporting, I agree that this feature makes sense :+1: I wonder what a decent API to expose this could look like. I think exposing this as part...
I agree that a custom interface would be best to also provide additional guarantees for type safety, documentation and IDE autocompletion. The problem with implementing a custom interface isn't really...
@boenrobot I think we're talking about something along the lines of this? ```php $browser = $browser->withRememberRedirects(true); $browser->get($url)->then(function (ResponseInterface $response) { echo 'Got a response: ' . $response->getStatusCode(); while ($response instanceof...
Still working out the details, but preliminary benchmark results suggest some noticeable improvements from 19810 req/s to 25032 req/s for the above example on my machine 🔥
Closed via #457 and #467. Remaining syscall optimizations will be done in stream and socket components and will be linked against this one.
@gizahNL Thanks for reporting! Can you provide a simple test script to reproduce the problem you're seeing?
@olegbaturin Thanks for reporting, I agree this is something that should be supported by this project :+1: PRs to address this very much welcome! :shipit:
@JustBeYou Excellent input, would love to see this in ReactPHP! The HTTP `Set-Cookie` request headers and `Cookie` response headers are indeed supported just fine in ReactPHP, but there's no automatic...
Providing an API to set and retrieve cookies isn't really too hard, but we'd also have to take persistence into consideration. I don't think there's an agreed upon standard, but...
> :wave: Unsetting a default header, would that happen through […] > > ```php > $browser = $browser->withoutHeader('User-Agent') > ``` @bartvanhoutte The idea is definitely to keep this in line...