filesystem
filesystem copied to clipboard
reactphp
Bumped child process packages and open up Windows support again
With the latest child process related packages adding support for windows again we can also open support for it again in this package
@clue Whoops this was supposed to be a draft PR. Wanted to do one last test run before opening it. In short all communication on the underlying dependencies goes over sockets rather then STD* and they all support react/child-process v0.6 by passing an list of overwritten file descriptors.
I agree that supporting the latest ChildProcess component makes perfect sense, but I don't see how this currently supports Windows? Perhaps split this into a separate follow-up PR?
For the reference, in case anybody's interested, here's an example how one could use socket I/O to communicate with a child process on Windows: https://github.com/clue/reactphp-sqlite/pull/13
@CharlotteDunois right!
@clue the messenger pool switched to fully using sockets in that release
@WyriHaximus That's great! Let's make this actionable, what makes this PR "WIP"?
@clue I can't remember 🤐 , will have a check on my windows box tomorrow
@clue Checked earlier today and it works on windows now. What do you think about adding an allowed to fail windows build on travis?
@WyriHaximus That would be fantastic! See https://github.com/reactphp/child-process/pull/71 for possible Travis CI config.
You'll probably want to add this utility method to the tests for cross compatibility paths. https://github.com/reactphp/filesystem/pull/69/files#diff-d4c8c6dc8769324fc27cfdac19f05cafR122-R131
@CharlotteDunois yup, I'll fix all the windows build issues in this PR 🤣
@CharlotteDunois just rebased and pushed it, will have a better look tomorrow