http-client icon indicating copy to clipboard operation
http-client copied to clipboard

chore(docs): remove leading dollar sign

Open nhedger opened this issue 3 years ago • 3 comments

See https://github.com/reactphp/http/pull/458

nhedger avatar Jun 20 '22 14:06 nhedger

Made sense to me because the first code block gives instructions to install the new reactphp/http component but I guess it's not absolutely necessary.

nhedger avatar Jun 20 '22 14:06 nhedger

I don't have any strong opinions on this one and I'm still not sure what to do about this PR, but I'm currently leaning towards not maintaining this component anymore as per #152/#153.

GitHub prominently features the date the project and individual files have been last updated, so I feel merging this PR might come over as this project being "resurrected". I'd rather convey the fact that this project is in fact "dead" prominently.

It's my understanding that if we accept this PR, there's reason to believe we should do more housekeeping for this project, like updating the failing test suite and more. Even if we don't do this ourselves, there's a chance somebody else might look into this and reasonably ask for a PR review. Personally, I'd rather spend time on working the current HTTP component instead.

clue avatar Jul 05 '22 07:07 clue

I agree. Wouldn't it make sense to archive the repository in that case ?

nhedger avatar Jul 05 '22 18:07 nhedger