Wenchen Fan comments

Results 245 comments of


                                            Wenchen Fan

[SPARK-48168][SQL] Add bitwise shifting operators support

Have we considered the operator precedence? Does it follow C? If yes let's add tests and document it. https://en.cppreference.com/w/c/language/operator_precedence

[SPARK-46632][SQL] Fix subexpression elimination when equivalent ternary expressions have different children

good catch! merging to master/3.5!

[SPARK-46841][SQL] Add collation support for ICU locales and collation specifiers

do we have end-to-end tests for this new feature?

[SPARK-46841][SQL] Add collation support for ICU locales and collation specifiers

thanks, merging to master!

[SPARK-47977] DateTimeUtils.timestampDiff and DateTimeUtils.timestampAdd should not throw INTERNAL_ERROR exception

it has merge conflicts, @vitaliili-db can you fix it?

[SPARK-47336][SQL][CONNECT] Provide to PySpark a functionality to get estimated size of DataFrame in bytes

@SemyonSinchenko thanks for the contribution! I have two high-level questions: - How do you use this sizeInBytes? Is it accurate in your workload? - Shall we expose more stats like...

[SPARK-48737] Perf improvement during analysis - Create exception only when it is necessary for default expression resolving

thanks, merging to master!

[SPARK-48747][SQL] Add code point iterator to UTF8String

thanks, merging to master!

[SPARK-48719][SQL] Fix the calculation bug of `RegrSlope` & `RegrIntercept` when the first parameter is null

thanks, merging to master!

[SPARK-48719][SQL] Fix the calculation bug of `RegrSlope` & `RegrIntercept` when the first parameter is null

can you open a backport PR for 3.5?