spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-46037][SQL] Correctness fix for Shuffled Hash Join build left without codegen

Open cloud-fan opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

This is a re-submitting of https://github.com/apache/spark/pull/43938 to fix a join correctness bug caused by https://github.com/apache/spark/pull/41398 . Credits go to @mcdull-zhang

Why are the changes needed?

correctness fix

Does this PR introduce any user-facing change?

Yes, the query result will be corrected.

How was this patch tested?

new test

Was this patch authored or co-authored using generative AI tooling?

no

cloud-fan avatar Aug 28 '24 08:08 cloud-fan

cc @szehon-ho @dongjoon-hyun @viirya

cloud-fan avatar Aug 28 '24 08:08 cloud-fan

thanks for the review, merging to master/3.5!

cloud-fan avatar Aug 29 '24 04:08 cloud-fan

Sorry guys was out (computer was stolen) and slowly going through emails. I must have missed adding the new case to this block when doing #41398 Thanks @cloud-fan and @mcdull-zhang for fixing this.

szehon-ho avatar Sep 17 '24 21:09 szehon-ho