Results 1376 comments of Chris Lalancette

I'll just say I appreciate the time you've put into this project (both in the past and more recently). When we did a survey of ways to generate this kind...

> flags="multicast,loopback,running" That's fine by me. I'll go ahead and implement it that way instead. > As such, perhaps the right place to do this is `net_if_stats()` and not `net_if_addrs()`:...

And this has all been done in b75a234. Please take a look when you get a chance.

I've now rebased this onto the latest, and resolved the conflicts in HISTORY.rst based on the release. This is ready for another review when you have time.

Rebased onto the latest again. Please take a look.

Friendly ping on this one; do you think we could get this in?

> I re-read your patch and I'm happy to include this functionality. I don't like hard-coding C constants in python though. I prefer if that is done in C. Thanks...

@giampaolo Thanks for the very detailed review! I've made a number of changes based on your review, though I opted not to make some of the changes you requested (individual...

So, as of right now, pycdlib supports creating UDF images, but only in the "bridged" format along with ISO9660. That is, the resulting disc will be a hybrid UDF/ISO9660 ISO....

Yeah, sorry, I see what you mean about this. Basically, we need to pass the vol_ident from the `new()` method down into the UDF creation stuff, and then set it...