Chenna Keshava B S

Results 241 comments of Chenna Keshava B S

hello @intelliot , I discussed the possibility of unit tests with @gregtatcam . He has already written compatibility unit tests here: https://github.com/XRPLF/rippled/blob/a948203dae52093960e38583b1bd8347368a07d4/src/test/overlay/compression_test.cpp#L483. These `handshake` tests ensure that if two peers...

@mDuo13 @ximinez @Bronek can you please review this PR? thanks!

Hello @scottschurr , Thank you for writing the unit test, it is helpful to visualize the context. Is this not the intended behavior? I'm of the understanding that Trust Lines...

I'm not able to run this script, perhaps I'm missing a dependency ``` $ python3 trustlineDel.py # I have used this file-name for your script. File "/Users/ckeshavabs/personal-code/rippled/cmake-build-debug/trustlineDel.py", line 1 const...

@mvadari Haha thanks for the clarification, my bad. Do you execute this with node.js runtime? The `customer` has not reset the settings to default from their end. So the trust...

Here's a [unit-test](https://github.com/XRPLF/rippled/compare/develop...ckeshava:rippled:AuthFlag) in C++ that seems to contradict your findings. It's a slight modification of @scottschurr 's code above. I've tried to mimic your javascript code in that unit...

Okay, I've fixed the mistakes in the previous iteration. Here's the unit test : https://github.com/XRPLF/rippled/compare/develop...ckeshava:rippled:AuthFlag If you reset the limits of the trust lines to the default, they are deleted...

@mvadari I have an update on this issue. There is an explanation for the difference in the behavior of C++ Unit tests and the Typescript libraries. many thanks to @ckniffen...

I'd like to reiterate the security concerns highlighted by Nik in commit 38c3a46a: ``` Deprecate commands that perform remote tx signing (RIPD-1649): In order to facilitate transaction signing, `rippled` offers...