rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Update sign-and-submit command to include accepted, broadcast, queued and other fields

Open ckeshava opened this issue 1 year ago • 4 comments

High Level Overview of Change

Fix #3284

This PR purports to make the response of the submit command identical -- irrespective of whether a binary blob or JSON is provided as input to the command.

Context of Change

The linked issue provides a description of the context of the change, actual and expected behaviors.

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

API Impact

This change adds accepted, queued, broadcast and other fields that were originally included in PR #3125

  • [x] Public API: New feature (new methods and/or new fields)
  • [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

Before / After

With this change, the cited example in the bug page (payment transaction from the genesis account) returns the expected behavior i.e. accepted, broadcast and other fields are returned in the output.

ckeshava avatar Jan 03 '24 23:01 ckeshava

@mDuo13 @ximinez @Bronek can you please review this PR? thanks!

ckeshava avatar Jan 03 '24 23:01 ckeshava

  • no perf impact expected. cc @sophiax851

intelliot avatar Jan 08 '24 23:01 intelliot

@ckeshava what's the status of this, from your perspective?

intelliot avatar Feb 28 '24 00:02 intelliot

As it stands, I don't have anything else to add to the PR

ckeshava avatar Feb 28 '24 23:02 ckeshava