Charles Kerr

Results 660 comments of Charles Kerr
trafficstars

Having read both PRs, both look well-written. And any volunteer who has the interest, skill, and patience to dig into Electron's + Chromium's codebase and patching system is someone we...

I would mostly be OK with either this or 41840. Both PRs have strengths and weaknesses; so if any other maintainer has strong feelings about which to use, TBH I...

I know how long this issue has been in limbo and was wondering, @callshots is this issue still happening for you in an up-to-date version of the app?

Hey, I know how long this issue's been in limbo and was wondering if this is still happening for you when you test with an up-to-date version of the app?

Hey @shsengar, I know this bug has been untouched for a long time and was wondering if this issue is still happening for you in an up-to-date version?

@erickzhao ping :smile_cat:

@beyondkmp I'd like at least one other person from @electron/wg-ecosystem to TAL too; but yeah, it's been two weeks. If nobody else reviews I'm :+1: on this PR

Looks like it was PR'ed, reviewed, and approved that way in #42690 :smile:

Digging a little further, it was added in a [commit](https://github.com/electron/electron/pull/42690/commits/88eb222b0af7b878eb460074b6fca64e7807a63c) whose summary is "summary must be followed by newline" so it looks like that section was a draft committed by...

@codebytere is this still something that should get merged? Looks like it got a couple of approvals but then stalled out