windows-installer
windows-installer copied to clipboard
feat: update nuget to v6.10.1
The current version of NuGet causes the CPU usage to be nearly 100% and the memory usage to be very high, almost 2GB during packaging.
Mem: 1.8Gi 1.7Gi 65Mi 2.0Mi 212Mi 114Mi
Swap: 2.0Gi 39Mi 2.0Gi
The latest version of NuGet only uses about 600MB of memory.
total used free shared buff/cache available
Mem: 1.8Gi 594Mi 61Mi 2.1Mi 1.3Gi 1.2Gi
Swap: 0B 0B 0B
The nuget downloads from https://dist.nuget.org/win-x86-commandline/latest/nuget.exe md5: 6b260d67fc4f18048347ae3c0d8e59bf
@ckerr Could you help merge it?
@beyondkmp I'd like at least one other person from @electron/wg-ecosystem to TAL too; but yeah, it's been two weeks. If nobody else reviews I'm :+1: on this PR
@ckerr, I believe the decision during the last Ecosystem WG meeting was to merge #526 to provide the escape hatch mechanism, but otherwise close these individual upgrades to NuGet and 7Zip, see Felix's comment here: https://github.com/electron/windows-installer/pull/526#pullrequestreview-2195217425.
Unfortunately this project is lightly maintained at the moment and we don't feel confident in updating these without more due diligence than we currently have bandwidth for. As such I'm going to close this PR, but we will hopefully revisit it in the future.
@ckerr, I believe the decision during the last Ecosystem WG meeting was to merge #526 to provide the escape hatch mechanism, but otherwise close these individual upgrades to NuGet and 7Zip, see Felix's comment here: #526 (review).
Unfortunately this project is lightly maintained at the moment and we don't feel confident in updating these without more due diligence than we currently have bandwidth for. As such I'm going to close this PR, but we will hopefully revisit it in the future.
@dsanders11
Some insight to bring up at your next discussion. Updating NuGet also fixes a variety of errors too -- see discussion on PR https://github.com/electron/windows-installer/pull/495. These aren't particularly easy issues to debug and I have doubts that even intermediate programmers will find and use the undocumented escape hatch.
I can only imagine using a 10yr old binary is going to cause even more bugs and issues for this under-staffed effort in the future anyways.
Perhaps worth re-consideration, I'm happy to help with the effort where I can.