Charles Kerr

This is a huge PR that will take some time to review, but a quick procedural question for @codebytere / @YuriL180821 just from reading this Conversation tab on GitHub: This...

I did a little initial digging, it looks like shell.openExternal() resolves down to ShellExecuteW @ https://github.com/electron/electron/blob/master/shell/common/platform_util_win.cc#L236 which uses whatever application is registered for the given URL as per the registration...

Pinging @MarshallOfSound for another look as per the Changes Requested

Hi @flurin-conradin, I totally get it that it's difficult to know what information to report when it's crashing mysteriously; however, you deleted the issue template and just included a screenshot...

I tested with some older versions to see if this is a new regression. This issue also exists in - 16.0.0 - 16.2.8 (latest stable 16) - 17.0.0 - 17.4.9...

I'm still getting a handle on this issue, but a partial status update: what's happening is `wcrtomb()` is failing in [base::SysWideToNativeMB](https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/base/strings/sys_string_conversions_posix.cc#56). It doesn't seem to be limited to combining characters,...

wcrtomb errno 84 Invalid or incomplete multibyte or wide character backtrace from the `mbtowc()` calll: ``` #7 0x55dfcccbf213 base::SysWideToNativeMB() #8 0x55dfccbb9411 _ZN4base8FilePath15FromUTF16UnsafeENS_16BasicStringPieceIDsNSt2Cr11char_traitsIDsEEEE #9 0x55dfd01854f9 blink::StringToFilePath() #10 0x55dfd0185751 blink::WebStringToFilePath() #11 0x55dfcb42c285...

I take that earlier comment back -- this _is_ an upstream bug; a variant of it is happening in Chromium too. To reproduce: 1. launch with LANG set, same as...

> Also, I was curious what the policy was for back patching something like this. Would it be possible to be back patched to v19? Or only v20? The Releases...

> @MarshallOfSound and @ckerr does the no-backport mean that this change will make it to 21.0 or 22.0? We'd really like to consume this as soon as we can and...