Riccardo Cipolleschi comments

Results 310 comments of


Riccardo Cipolleschi

Fix Application always in light mode on initial load.

I restarted the jobs but they are still failing. Let's try to rebase on top of main, but I think that there is something wrong here.

Fix Application always in light mode on initial load.

/rebase - this comment automatically rebase on top of main

Remove `getSurfacePresenter` and `getModuleRegistry` from RCTHost

landed https://github.com/facebook/react-native/commit/f19371f28ddbb660ed08a3e38aef85f27f0876a7

Extend Property Processor to support long properties

landed 0a80270187c05fe2da1f25fb8a8426fd4f03f8f2

change order of build steps, delete unused drivers

@Othinn is this PR still relevant for the e2e effort?

Allows interactive dismissal of modals on iOS

Hi @ChrisSchofieldCheckatrade, thanks for your contribution. As you might have seen, yesterday, some time after you opened your PR, another PR landed that changes the structure of the Modal codebase,...

Allows interactive dismissal of modals on iOS

Hi @ChrisSchofieldCheckatrade, just an update not to keep you hanging. Last week we landed the change on modal for which I asked you to rebase and update this PR. Than,...

Allows interactive dismissal of modals on iOS

@ChrisSchofieldCheckatrade many thanks for your understanding, I really appreciate it. I'll keep you in the loop to make this happen!

Allows interactive dismissal of modals on iOS

Not for now, I think I can split it pretty easily, thanks! One of the two commit will still be attributed to you as contributor. If you want to have...

feature: Update `Image.getSize/getSizeWithHeaders ` methods to return a promise

/rebase - this commet will rebase the PR on top of main automatically. All these changes are JS changes only, there is no reason why the native builds should fail....