react-native
react-native copied to clipboard
change order of build steps, delete unused drivers
Summary:
After checking failed e2e jobs I've noticed that job test_e2e_android and test_e2e_ios have some steps that can be rearranged to run after the build command. This change will reduce the time of idle metro and appium server and maybe will reduce flakiness. I've deleted installing unused appium driver(xcuitest for android, and uiautomator2 for ios) Reduced no_output_timeout to 10min. I think that there's no case that we need to set it to as high as 30min when whole test suite only takes around 10min
Hi @Othinn!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 17,227,238 | -421,787 |
android | hermes | armeabi-v7a | n/a | -- |
android | hermes | x86 | n/a | -- |
android | hermes | x86_64 | n/a | -- |
android | jsc | arm64-v8a | 20,595,437 | -431,221 |
android | jsc | armeabi-v7a | n/a | -- |
android | jsc | x86 | n/a | -- |
android | jsc | x86_64 | n/a | -- |
Base commit: fbd8504cc0df8d65fd1782eafcab7b9d464d539b Branch: main
Fails | |
---|---|
:no_entry_sign: |
:clipboard: Missing Changelog - Please add a Changelog to your PR description. See Changelog format |
Warnings | |
---|---|
:warning: | :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
:warning: |
Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link |
:warning: |
Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link |
Generated by :no_entry_sign: dangerJS against e86e1da2a4b413ace2b6822251a32718811a1899
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
@Othinn is this PR still relevant for the e2e effort?