Surelog

Surelog copied to clipboard

'make install' installs capnp

1

When running `make install`, also the capnp dependency is installed, binary and library. This looks unintentional, as it will mess up the target system.

hzeller

Running `make install` also installs UHDM headers in the prime prefix location. This looks unintentional as it will mess up a regular installation. If it is intentional that the headers...

hzeller

Antlr4 warm-up times - can this be improved/pre-computed ?

9

We'd like to add Surelog to [sv-tests](https://github.com/SymbiFlow/sv-tests), see this https://github.com/SymbiFlow/sv-tests/pull/447 pull request. However, currently the tests are using more time that can be allocated by the continuous integration sysstem, so...

hzeller

We already have the generated code checked in, so it should be possible to compile the code even if the jre is not installed. CMake figures out the dependency. Unless...

hzeller

Options: Make gnu conform: Make long options start with double-dash

4

`surelog -help` works, but the more common expected name `surelog --help` does not (this is a [gnu-convention]) Short options should be understood with or without space in the middle. `surelog...

hzeller

Switch from flatbuffers to Cap'n'Proto

1

For all the [SymbiFlow project](https://symbiflow.github.io) we are standardizing on [Cap'n'Proto library](https://capnproto.org/). > Cap’n Proto is an insanely fast data interchange format and capability-based RPC system. Think JSON, except binary. Or...

mithro

Methods that have been marked `virtual` in a base-class ``` class A { virtual in foo() = 0; virtual int bar() = 0; }; ``` should be marked override or...

hzeller

Not sure how big the arrays are, but `body` sounds pretty big. These are passed as std::vector value. They probably meant to be const references to that vector ? ```...

hzeller

Abseil is a common c++ library that compiles with c++11, but provides features (such as `absl::string_view`) only appeared in c++17. In particular a lot of string copy operations might be...

hzeller

To denote output parameters, it is best practice to use pointers instead of references to avoid confusing call site where it is not clear that the content would be modified:...

hzeller