cherrymui

Results 215 comments of cherrymui

I don't think we need to change the convention for regular Go functions and Go assembly code. The system ABI requires FP be saved at a word below the LR,...

> It seems to me that the size of a WASM function is limited to 2^16 = 65536 bytes? > `ldr.SetSymValue(s, int64(funcValueOffset+va/ld.MINFUNC)

It is not a regular PC. `PC_B` only increments per "resume point", which is essentially per basic block. How many instructions in a basic block and how many bytes are...

It is not the basic block number limit, but the total number of (reachable) functions. As you saw in the comment above, `PC = PC_F

CL https://go.dev/cl/552835 changes the method table encoding to allow more than 65536 functions. Now https://github.com/HarikrishnanBalagopal/move2kube/tree/feat/starlark builds. Could you test if the resulting binary is correct? Thanks. I don't really like...

Thanks for trying the code and posting the error message. It seems the function table will need a similar update. I'll look into that. > Is it necessary to keep...

I was OOO last week and I'm just back. I'll work on the function table change. Thanks.

Not yet. Still working on it. I hope to get a new version of the fix by this week.

@HarikrishnanBalagopal could you try the new version of CL https://go.dev/cl/552835 ? Thanks.

@dunglas thanks for the update! The reason why this is musl specific is probably that the code getting the stack bounds https://source.corp.google.com/h/go/go/+/release-branch.go1.22:src/runtime/cgo/gcc_stack_unix.c;l=24 uses different code paths for glibc and musl....