Chris Hennes
Chris Hennes
Thanks for the PR! This adds a new state to the code, so needs some further testing. In particular, the state is only set inside the mouse handling code, but...
I'm switching this to draft pending updates to the code to ensure that state is correctly set and reset under other code paths.
@wsteffe or @PaddleStroke do you have any suggestions?
@FlachyJoe does it seem like there is a possibility to fix this?
@Connor9220 or @ipatch do you have time to bisect?
I just tried this and did not get the failure -- maybe I didn't follow the steps exactly? I've attached my FCStd file with ten occurrences of the subtractive pattern....
OK, here's the failure's backtrace: ``` segmentation_fault_handler(int) Application.cpp:1848 0x00007ffcd48fe8a4 0x00007ff706b96cb6 0x00007ffcd492156f 0x00007ffcd70c796f 0x00007ffcd6fd6397 0x00007ffcd70c72ae 0x00007ffbed7039d9 0x00007ffbed7c3437 fixFace(const TopoDS_Face &) modelRefine.cpp:496 ModelRefine::FaceTypedCylinder::buildFace(const std::vector &) modelRefine.cpp:677 ModelRefine::FaceUniter::process() modelRefine.cpp:1066 Part::BRepBuilderAPI_RefineModel::Build(const Message_ProgressRange &) modelRefine.cpp:1284...
@pieterhijma is going to check to see if it crashes with refine=false.
@pieterhijma will test