Chris Hennes

Results 699 comments of Chris Hennes

> * Url links - About | License still has Dark Blue links - I thought this had a PR and commit by chennes The license tab is generated in...

The license/credits tab isn't created in Qt Designer, the one in there is just a placeholder. It gets replaced in the code that generates the About dialog by reading in...

I don't think we can block the release of 1.1 on every "FreeCAD does something unexpected" issue out there -- @Roy-043 is there something making this one particularly dangerous? 1.1...

FYI: Regardless of any personal preferences elsewhere, we cannot make this change to any addons' namespace URI, which has to remain all lowercase.

https://github.com/FreeCAD/FreeCAD-render/commit/9f35d303a4bd12ef8b8bef17b63ab6978d90047b (fixed in https://github.com/FreeCAD/FreeCAD-render/commit/acdb8ccd0961c0e0ecc70ee3369f4fe75073cc5e). Regarding the case change: this is clearly not yet an "identified and agree upon issue" (per https://github.com/FreeCAD/FreeCAD/blob/main/CONTRIBUTING.md). So no action should be taken on it until...

I've rebased and added a commit that makes the requested additional change.

@furgo16 that's a good point, and probably right (and also right that @baidakovil shouldn't do anything about it right now :) ). Can you create an Issue for it so...

@yorikvanhavre is going to take care of those three unused imports and then this is good to merge.

I don't understand this placement of the calls to `themeChanged` -- why is it happening in the button setup method?

This isn't really a Start WB thing -- remember that Start is optional, and it's possible to run FreeCAD without it. If we need to actually execute a preference pack...