Chris Hennes

Thank you for the review, @bofdahof. > A LOT of repetition... In the tests, do you mean? Or are you concerned about the structure of the method itself? > The...

> And finally, as an old dude, I can confirm that years before 2001 are real. But it's not possible for a FreeCAD macro to have been written before then...

I've eliminated the duplicate calls to `int()` -- since it's not actually valid as a date to have `split_result[1]` be the year, it didn't seem clearer to me to attempt...

Massaging that code into non-pseudocode that passes the tests gives something like: ``` def process_date_string_to_python_datetime(string: str) -> datetime: could_be_year = lambda x: x.isnumeric() and int(x) > 2000 # Addon creation...

Fortunately I don't have to support an open set of any possible date formats: we now require the use of ISO 8601 formatting in new macros, so only the set...

(Note to maintainers: I only left the commit history intact to make the review process clearer, this can get squashed on merge).

> Midplane was deprecated by the pad rework since now it's handled by the SideType property. "Deprecated" in this case seems to mean "removed" -- I don't see this in...

> Is this really a blocker? IMO yes -- and I think it's not terrible to resolve, @adrianinsaval had a good suggestion for it in this morning's meeting.

I'm thinking something like: ```C++ void FeatureExtrude::onChanged(const App::Property* prop) { if (prop == &Midplane) { // Deprecation notice: Midplane property is deprecated and has been replaced by SideType in //...

I'm having some trouble testing this: I've had to make some tweaks to the script to get it working in 1.1, but I'm still not getting a functional pad. What's...