Chris Hennes

Results 699 comments of Chris Hennes

As @FlachyJoe notes, the long-term solution to this is to break apart the `DocumentRecovery` classes to separate the GUI part from the business logic, allowing later re-use of the recovery...

@mnesarco if you're going to adjust the copyright headers, better use the brand-new formatting that @PhoneDroid has documented here: https://github.com/FreeCAD/DevelopersHandbook/blob/main/codeformatting/Copyright-Snippets.md

Thanks for the PR, @xelathan -- my only hesitation is that with two mutually-exclusive options, we really don't have a boolean state anymore, it's effectively an enumeration (something like "None",...

@xelathan we are waiting on merging this pending your response to @pieterhijma's comments.

@xelathan do you have any questions about @pieterhijma's review?

Does the Draft unit test suite still pass if BIM is disabled?

The linter is complaining about the block length, which went from 202 to 204 lines -- it's beyond my meager Ruby skills to refactor this code in any sensible way....

> The title on this commit "Refactor utilities tests to remove filesystem use" seems unrelated to the content? It looks like I mis-squashed the various commits here: I'll pull it...