Christopher Dignam

Results 173 comments of Christopher Dignam

For implementation we'd need to update the main GraphQL query to also fetch comments. https://github.com/chdsbd/kodiak/blob/f3d2dc9c760a49b15f955cec9d3e35df4486d5a3/bot/kodiak/queries.py#L61-L208 We'd also need to add a new configuration option. https://github.com/chdsbd/kodiak/blob/f3d2dc9c760a49b15f955cec9d3e35df4486d5a3/bot/kodiak/config.py#L48-L67 Using the new comment information,...

@sanmai-NL I think that could probably work, the caveat is that Kodiak doesn't have great support for code owners (#96).

I haven't looked into this too much, but I think you might be able to use this branch protection setting depending on how your organization permissions are setup. You'd need...

@JohannesRudolph Thanks for making this PR! Using GitHub Actions is a neat trick. I also think the API solution from https://github.com/tibdex/github-rebase could be interesting if it doesn't require too many...

@ehamiter Would you be willing to merge a PR (I could make it) that adds this feature?

@madzak Would you accept a PR for this?

It seems like pg_query.rs has a [`CommentStmt`](https://github.com/pganalyze/pg_query.rs/blob/264167f4825b0a4c8fa7313db7acd9f72efb4829/src/node_ref.rs#L76), which might work. Here's the related [`pg_query.proto`](https://github.com/pganalyze/libpg_query/blob/d1d0186b80c1fbf496265789af89da4e7ca890ab/protobuf/pg_query.proto#L90).

@adamrdavid That's too bad that doesn't work. I feel like we need to do something ourselves to parse our comments vs SQL.

Heroku has a pretty simple solution of using config variables pointing to static page urls: https://devcenter.heroku.com/articles/error-pages#configure-your-application. So a user could set a config variable `MAINTENANCE_PAGE_URL` pointing to some static site...

I think you misunderstand. I created a resource that matches the Heroku config, but when I import, the heroku provider doesn't import the config version. Edit: by "config", I literally...