Christopher Dignam comments

Results 173 comments of


                                            Christopher Dignam

Importing postgres-db doesn't import config version

@mars I've updated my expected behavior a bit. Please reopen this PR.

Importing postgres-db doesn't import config version

I think I found the bug. Please see the updated references section of this issue.

Importing postgres-db doesn't import config version

Thanks for looking that up @davidji99. It seems like this should be labeled "Heroku API Support".

Importing postgres-db doesn't import config version

~~Actually, on second pass, I think this endpoint might work: https://devcenter.heroku.com/articles/platform-api-reference#add-on-config-list~~ __EDIT__: This is the endpoint for fetching `config_vars`, not `config`.

Return boolean after send?

@brianleung24 A return value isn't possible because by sending UDP packets to telegraf, pytelegraf doesn't cannot know if they were received or not. It's "fire-and-forget" with UDP.

Restrict merges to PRs older than a certain threshold

I think this is doable. Maybe not the easiest change for a new contributor because we'd need some cron-like functionality. I think we'd store a PR for reevaluation after some...

fix: RunCommand calling scripts with incorrect executable path

My test is hacky. Any tips on cleaning it up would be appreciated.

fix: RunCommand calling scripts with incorrect executable path

@sdispater This is ready for review

fix: RunCommand calling scripts with incorrect executable path

This is still something I'd like to fix in poetry. I'll fix the conflicts when I get a commitment that this will be merged.

fix: RunCommand calling scripts with incorrect executable path

@wagnerluis1982 Thank you. That would be great!