kodiak icon indicating copy to clipboard operation
kodiak copied to clipboard

Hide merge button on GitHub

Open sanmai-NL opened this issue 4 years ago • 6 comments

I can still see a merge button under PRs, even though Kodiak is active. Is there a way to force exclusive push access by the bot to the default branch? And in addition, to hide this button?

sanmai-NL avatar May 05 '20 14:05 sanmai-NL

Currently there isn't anyway to ensure that only kodiak merges PRs. I think its something we could add via branch protection and a status check that only kodiak can set, but it's a bit of work.

For hiding the button Shopify has a browser extension they outline in https://engineering.shopify.com/blogs/engineering/introducing-the-merge-queue that hides the merge button to better integrate with their merge tool shipit.

Definitely possible to do something similar for kodiak, or even via a stylus rule.

sbdchd avatar May 05 '20 22:05 sbdchd

@sbdchd, great. I'm first going to look into those options.

sanmai-NL avatar May 06 '20 07:05 sanmai-NL

@sbdchd: Would it be possible to add @kodiakhq as code owner and require its 'review'?

sanmai-NL avatar May 06 '20 10:05 sanmai-NL

@sanmai-NL I think that could probably work, the caveat is that Kodiak doesn't have great support for code owners (#96).

chdsbd avatar May 07 '20 00:05 chdsbd

I haven't looked into this too much, but I think you might be able to use this branch protection setting depending on how your organization permissions are setup. You'd need to allow Kodiak to merge pull requests.

image

chdsbd avatar May 12 '20 23:05 chdsbd

That's what I use now.

image

I think the merge button is still visible for admins though.

sanmai-NL avatar May 13 '20 08:05 sanmai-NL