GitHubinator icon indicating copy to clipboard operation
GitHubinator copied to clipboard

Published 20 hours ago • verified publisher icon ehamiter

Add open pullrequest button

Open aukehuizinga opened this issue 6 years ago • 3 comments

It would be really nice to have an "open pullrequest" button also.

aukehuizinga avatar May 30 '18 14:05 aukehuizinga

@ehamiter Would you be willing to merge a PR (I could make it) that adds this feature?

chdsbd avatar Jul 23 '19 19:07 chdsbd

That seems outside the scope of what this plugin does-- namely, opening a github page that shows highlighted lines. It just seems like it would be tacking on other features that don't have anything to do with this. Currently this plugin supports Bitbucket as well, so that would need to be taken into account. I'm leaning toward "no" unless a lot of people would agree it would make a good fit. I think it would be fine as a standalone plugin, though, if you're up for creating one.

ehamiter avatar Jul 23 '19 21:07 ehamiter

I think having a "show highlighted lines in pull request Files Changed tab" feature would be super useful for reviews. Not sure how doable it is.

Supporting Bitbucket is weird considering the name of this plugin.

JGJP avatar Jul 14 '21 04:07 JGJP