chavacava

Results 66 comments of chavacava

@generalmimon please check PR #27

Hi @burdiyan, I'm trying to reproduce the problem but without success at the moment. Target file (`deleteme.go`) ```go // Some nice doc for the pkg... package main import "errors" var...

Unable to reproduce the problem. Closing for now.

Hi @twmb, thanks for filling the issue. Well, even if documenting `main` packages might be not so common, the [official guideline for documenting GO code](https://tip.golang.org/doc/comment) says they should be documented:...

> We have meet this problem, too. but we are not main package. > > util/texttree/texttree.go:15:1: package-comments: should have a package comment (revive) > > https://github.com/pingcap/tidb/blob/a80078538d366d55acfc34dd772b1977a720a9bc/util/texttree/texttree.go#L14-L16 Hi @hawkingrei , I've...

> As well, main packages do not follow the common `Package main ...`, as seen in the linked post above. Yes, [`revive` takes that into account](https://github.com/mgechev/revive/blob/553604eaced55ff3b0262525fa1cc19233cce297/rule/package-comments.go#L153)

Hi @chen3feng, thanks for filling the issue. I do not remember why this exception was added. As you said, it could be configurable. For backward compatibility reasons, if we add...

Hi @hansgylling, I'll be glad to help you with the PR process.

@doniacld there are still some references to `go get` in the project documentation

`revive` has more than 65 rules and, of course, there is some overlap with those of the other linters `golangci-lint` can run. When looking for potential bugs I use the...