revive icon indicating copy to clipboard operation
revive copied to clipboard

Update instructions from using go get to using go install

Open hansgylling opened this issue 3 years ago • 3 comments

Describe the bug The project have some old files with instructions that tells the reader to use go get -u to install revive. I believe this should say go install nowadays. The files I have seen so far are DEVELOPING.md and .github/ISSUE_TEMPLATE/bug_report.md, but it could be a good idea to look for more instances with grep -r -F 'go get'

hansgylling avatar Aug 19 '22 15:08 hansgylling

Hey @hansgylling do you want to open a PR with the update?

mgechev avatar Aug 24 '22 18:08 mgechev

Yes, I was thinking I could fix it myself. I didn't have much time when writing the bug, but could do it now. I have ran the grep command I suggested and didn't find any other file.

I will say that I'm not used to Github (we use Gitlab at work) and I haven't made any pull request on Github yet, so I will need to figure that out and may make some mistakes along the way. We'll see.

hansgylling avatar Aug 26 '22 12:08 hansgylling

Hi @hansgylling, I'll be glad to help you with the PR process.

chavacava avatar Aug 27 '22 11:08 chavacava

@chavacava I think the issue is fixed, you can close it.

doniacld avatar Oct 01 '22 07:10 doniacld

@doniacld there are still some references to go get in the project documentation

chavacava avatar Oct 01 '22 09:10 chavacava

@chavacava I'd be happy contribute these updates to the docs.

attiss avatar Oct 02 '22 00:10 attiss

https://github.com/mgechev/revive/pull/750

attiss avatar Oct 03 '22 16:10 attiss

Thanks for doing this. I said I would do it, but I've been very busy with work and life.

hansgylling avatar Oct 04 '22 08:10 hansgylling