chavacava
chavacava
The chosen configuration of `golangci-lint` does not include `revive` thus there is still the risk of not detecting bugs as those mentioned in the initial message of this discussion.
Hi @vposhamod thanks for filling the issue. You can completely disable these rules (on _actual code_ and on tests) through [configuration](https://github.com/mgechev/revive#configuration): ```toml [rule.line-length-limit] Disabled = true ``` Does that solve...
I misunderstood your first comment ("_I would like to **exclude** some rules ... on **actual code** ..._"), my bad. Using the command line flag `-exclude` might be too coarse grain:...
Hi @jBugman, thanks for reporting this issue. I will work on it this week.
Hi @jBugman, I've tryed to reproduce the bug with ```go import ( "fmt" ) type r struct { s s } type s struct{} func (s *s) returnsError() error {...
It seems that the problem is not related to imported structures, `revive` behaves as expected for the following code: ```go import ( "net/http" ) func foo() { (&http.Request{}).MultipartForm.RemoveAll() } ```
The rule needs type information to identify functions returning values of type error, that is why at the beginning of the rule execution over a file, it performs type-checking on...
Hi @dschveninger, thanks for filling the issue. Changing all internal declarations and references to `whiteList` and `blackList` seems OK and without risk. On the other side, changing rule names (like...
Hi @Gusted thanks for filling the issue. >Using the _ prefix is common in JS to still have the variable name but show that the variable is unused. It is...
>Is it out of question to have a rule configuration option for this? Not at all. My intention with the previous comment was to highlight that prefixing identifiers with `_`...