Simon Charette
Simon Charette
The code changed a lot in the past 4 years and since I've never required support for m2m I never got into fixing everything. People interested into getting this fixed...
@claudep you might also be interested in https://github.com/django/django/commit/f333e3513e8bdf5ffeb6eeb63021c230082e6f95#diff-1c8b882c73bfda668d5451d4578c97191b0ebc0f088d0c0ba2296ab89b428c44R1053 which just landed through #16860 (ticket-16860). `AutoField` on Postgres is backend by a `id INT GENERATED ALWAYS AS IDENTITY` so maybe the...
I tested out the above and it unfortunately doesn't work out of the box because `IDENTITY` must replace the `STORED | VIRTUAL` suffix as well as avoid double parentheses wrapping....
@felixxm no objections from me, this should only cause a slowdown on custom `migrations.Operation` subclasses out there that use `state.apps` in their `state_forwards` as none of the core ones do...
@DevilsAutumn, thanks for the patch. Per [this comment](https://code.djangoproject.com/ticket/32263#comment:7), did you explore ticket-32256 7c18b22e2fa70aa8dcfadb33beb17933abdf7ee4 solution but adapted to `RenameModel` instead of `RenameField`? It seems that the main issue here is the...
@shangxiao > I wonder if we should also add a test around _output_field_or_none though it could be a bit too trivial 🤔 I think it might be worth it yes...
BTW I also just noticed `_output_field_resolved_to_none` which gets assigned in `output_field` and it seems that flag might also warrant clearing? I wonder if its existence warrants the usage of a...
I like the `OutputFieldIsNoneError` approach a lot, it seems like it should have been this way in the first place. One small tweak I would make; the whole `except FieldError:...
@nessita I think that using a `cached_property` should be fine as `Q` objects, like most expressions-like objects, are not meant to be altered in place but cloned before hand. This...
> I'm not sure what you mean by that, I don't think we can, because Options.pk refers to the field, while Options.primary_key is the list of field names. You're completely...