Simon Charette

Results 168 comments of Simon Charette

I'd focus this PR on `JSONArray` and see what can be done for `JSONObject` in a distinct ticket/PR? A potential solution could be to require that fields are provided as...

@john-parton 5.2 is feature frozen at this point so that would be 6.0.

It's issues with the CI infra, force-pushing an amended commit should do assuming the problem was transient.

This is awesome @jacobtylerwalls! Do we have a plan to handle potential `Expression` and `Lookup` subclasses in the wild that might be returning `tuple[str, list]`? It might already have been...

The usage of `sum` here is interesting. Not sure if we simply want to change `start` to `()` or use `tuple(chain.from_iterable(params))` instead.

The unveiled failures are related to [this ticket](https://code.djangoproject.com/ticket/33312) TL;DR the [documented pattern for copying model instances](https://docs.djangoproject.com/en/5.2/topics/db/queries/#copying-model-instances) breaks when some fields are deferred on the original instance. This poses a problem...

Thanks to everyone for the review a particularly @felixxm for seeing this through 🎉 🙇