django icon indicating copy to clipboard operation
django copied to clipboard

Fixed #34841 -- Avoided rendering apps on state still requiring mutation

Open shangxiao opened this issue 8 months ago • 3 comments

https://code.djangoproject.com/ticket/34841

shangxiao avatar Sep 14 '23 18:09 shangxiao

@jarshwah, hi. Interested in checking whether this patch speeds up reverse migrations for you?

shangxiao avatar Sep 16 '23 11:09 shangxiao

@shangxiao Do you have time to keep working on this?

felixxm avatar Nov 20 '23 12:11 felixxm

@shangxiao Do you have time to keep working on this?

Yep 👍

shangxiao avatar Nov 20 '23 12:11 shangxiao

@charettes Do you think this is an acceptable improvement?

felixxm avatar Mar 22 '24 04:03 felixxm

@felixxm no objections from me, this should only cause a slowdown on custom migrations.Operation subclasses out there that use state.apps in their state_forwards as none of the core ones do anymore so I think this is a good tradeoff.

charettes avatar Mar 22 '24 20:03 charettes