Simon Charette

Results 171 comments of Simon Charette

@camuthig I usually try two approaches on my M1 1. I had success once I ran `brew install colima` and tried again 2. Low-tech approach is to attempt to generate...

I managed to get tests running on Oracle here's the non-localized error message ``` ====================================================================== ERROR: test_annotate_values_list (aggregation.tests.AggregateTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/django/source/django/db/backends/utils.py", line 105, in _execute...

@camuthig that's awesome, thanks for the summary! Sure we can give the Oracle suite a run and see how it goes. I have the VM setup locally now so I...

@camuthig I believe it should yes or that we can add you to an allow list otherwise. Could you trying `buildbot, test on oracle.`

One reported failure with the associated query ``` ====================================================================== FAIL: test_string_agg_filter_in_subquery (aggregation.tests.AggregateTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/django/source/tests/aggregation/tests.py", line 2329, in test_string_agg_filter_in_subquery self.assertQuerySetEqual(expected_values, values, ordered=False) File "/django/source/django/test/testcases.py", line...

I think we'll have no choice but not to support `StringAgg(filter)` on Oracle (we could raise `NotSupportedError` in `as_oracle` given `self.filter`) because `LISTAGG` doesn't offer a way to filter out...

@camuthig I think the following should address the Oracle GIS failures ```diff diff --git a/django/contrib/gis/db/models/aggregates.py b/django/contrib/gis/db/models/aggregates.py index abff1a5206..e526a8d3ef 100644 --- a/django/contrib/gis/db/models/aggregates.py +++ b/django/contrib/gis/db/models/aggregates.py @@ -33,15 +33,14 @@ def as_oracle(self, compiler,...

> Oracle appears to be casting null to a string and getting '' instead. @camuthig the reason for this is this is that [for Oracle](https://github.com/django/django/blob/f4813211e2d8017b56b7447f56ad17df3fae9aa3/django/db/backends/oracle/features.py#L16) `NULL` and `""` (empty string)...

> Therefore, we see that the default argument does not work with JSON_GROUP_ARRAY on SQLite. I think we should change this behavior for SQLite? Do you an idea how to...