Jonathan Chappelow

While this PR addresses a legit issue with using a lock for two conflicting purposes, potentially resulting in a panic (rather than a deadlock which was the issue recently resolved...

This was resolved in https://github.com/googollee/go-engine.io/pull/86, with fix in current go-socket.io code.

Gave it a test on mainnet and there were no more single cfilters requests, just big chunks of blocks, which is great. Not always 1000, but never just 1.

I think we might want to eliminate the /side page. There's nothing particularly special about them, and transactions will already list any side chains in which they appear. e.g. https://explorer.dcrdata.org/tx/fcf79a095661819ca980fcefa120edf228dad650527a7071105ff2fc7b12f866

That must be visible only on desktop? 

Oh, duh it's because the backend we're hitting hasn't imported that side chain yet.

LOL, I think that underscores the need for the disclaimer or removing the page.

Currently a lost dcrd connection is bad news and there is currently a PR to disable autoreconnect: https://github.com/decred/dcrdata/pull/1130 In the future, a better solution that detects disconnect and reconnect can...

sounds good @orthomind

Yes, it is. It's probably just a few commands, but it's valuable as an example at least.