Jonathan Chappelow

Results 191 comments of Jonathan Chappelow
trafficstars

Just considering how this might play out and if there would be any fallout for btcd module consumers at say v0.22.0-beta, the pkg.go.dev site indicates that the previous package was...

If this is done, just need to be extra careful to avoid the even worse nightmare of an ambiguous import (e.g. https://github.com/btcsuite/btcd/issues/1839#issuecomment-1111642262, which was eventually resolved in https://github.com/btcsuite/btcd/pull/1851). So, for...

Thanks a ton for both https://github.com/btcsuite/btcd/pull/1823 and https://github.com/btcsuite/btcd/pull/1824. :pray: Really helpful to a lot of consumers, I think. In this PR, I'm curious about the new submodules: `btcutil/address`, `btcutil/bech32`, `btcutil/psbd`,...

> We still require a separate module for `btcutil/address` because that resolves the circular dependency between `txscript` and `btcutil`. Ahh, yes, `Address` et al. is in btcutil! Down in dcrd,...

From my point of view (a consumer), this is looking great. Looks like one of the last packages I import that will still come from the main `btcd` mega-module is...

Given recent issues, txscript should really start at `txscript/v2` on account of the breaking changes since `v0.22.0-beta`. Two issues have popped up since where a txscript build error was hit...

The more I think about this, the more I think inferring the PkScript from witness data is not possible. The witness script version is part of the pkScript itself, and...

This would be a nice option. If it's still conceptually alright by jrick I expect you'll need to resolve a couple years of conflicts @sefbkn

In my experience (at the time) if you let the wallet run indefinitely, you will get to a point where there is no (or very little) unconfirmed, yet you've fully...

That's not my recollection. I suggest running testnet wallets with and without mixing, with a non zero balancetomaintainabsolute. I think in both case it's not just unconfirmed _or unmixed_ change....