Chris Fallin
Chris Fallin
It would definitely be nice to have support for this -- in principle we could return two blobs of bytes as the result of per-function compilation instead of one, and...
I tried briefly to trigger something interesting, but got stuck at trying to get clang (on macOS/aarch64) to use the short-form LDR-with-immediate instruction; for any load from rodata it seems...
Note that this is spun out of #12133, and makes tests pass there, in lieu of hacking up a Cranelift runtest harness for editing patchable code here (the failure would...
Ah, yep, sorry, I forgot that we have 32 vector registers on this platform. Thanks for the review! I've updated to use `STMG` / `LMG`; opting not to try to...
The s390x failure looks like an oversight on my part in the patchable-ABI implementation on that ISA -- the clobber-save code implicitly assumes that clobber set fits in that ABI's...
Fixed s390x in #12148; that commit is also on top here to see the fix in CI but I'll rebase out once that merges first.
OK, I'm going to go ahead and merge based on Nick's approval here -- thanks Alex and Nick for all the comments!
I had to add some icache coherence handling for aarch64 to make macOS/aarch64 happy in CI (curiously did not reproduce locally on my M1 laptop; but there could be several...
(That commit should properly fix #3310 once it merges as well.)
Thanks for filing this! The main difficulty with doing this today is that our instruction-coloring pass computes colors once, and updates colors on all loads and stores; in essence this...