Chris Fallin

Yes, that's what makes the transform possible, I agree. My description is how lowering works today, so we will need to update the instruction coloring algorithm as noted.

(The reason that notrap loads still participate in coloring is that they should not be moved across stores; and moving across stores is governed today by coloring, not alias analysis)

Unfortunately I don't think this is going to work: the stack pointer has to be 16-aligned, and aarch64 will actually trap if memory accesses occur with a misaligned SP. Furthermore...

Right -- we already omit frame pointers for functions that are truly leaf functions (no calls at all, with no frame storage); this is a common optimization. In Wasmtime, where...

I think you'll want to check the tail args and outgoing args size as well (the other parameters to `compute_frame_layout`) -- basically, if any part of the frame needs to...

@bjorn3 thanks for the thoughts; we have thought pretty extensively about this and we think the unwinding-based approach is probably not viable in our no-std embedding (see Zulip thread that...

@bjorn3 thanks for this analysis. Most of these we have answers to already, I think. - Nick covered anyhow above. (Replace our error types with non-allocating versions, and layer allocations...

Could someone remove me as the requested reviewer? (@sunfishcode?) I'm cleaning up old review requests and still have this one on my queue but no permissions to remove myself or...

@cceckman-at-fastly @dgohman-fastly as two recent committers, it looks like you have rights to do so -- could you please remove me as a reviewer on this old PR?

Thanks for writing this up! I agree we should do this; also it might be a good first issue (I'll add the tag). One particular thought on > but that...