Cee Chen

Results 307 comments of Cee Chen

Thanks for posting that super detailed comment @henry-young! > It would be nice to have a list of icons the component uses in the docs. Maybe I'm missing something, but...

Ah, you're totally right, I missed that context, apologies! We're not likely to update our docs to include a list of all icons each component uses as SSR consumers are...

I'm also a little worried about possible unintended changes as a result of this fix. I'm wondering if it makes more sense to make this a prop that sets the...

Thanks for the `isCapture` prop update Patryk, the new changes look great. Could we potentially scope this PR down further to only affect specific desired components that you need? For...

@patrykkopycinski can you be a bit more specific about what in the Lens flyout requires either an `EuiPopover` or `EuiSelectable` to have a configurable capture event? Is there a popover...

The example in https://elastic.github.io/eui/#/tabular-content/tables#adding-sorting-to-a-table is essentially changing the table data set to `items` based on how `sorting` changes. The reason why EuiBasicTable is so agnostic to the data going in/out...

This could tie in / be fixed at the same time we remove our dependency on `data_store` as well 🤷 https://github.com/elastic/eui/issues/5837

[A solution similar to EuiDataGrid](https://github.com/elastic/eui/blob/d794a70a3305e97b4d8d3dc5c8435b85d50781f1/src/components/datagrid/body/data_grid_cell_popover.tsx#L72) might work - EuiDataGrid makes use of a single `EuiWrappingPopover` whose `button` anchor changes depending on what triggered it.

Can confirm this is reproducible when no cache is passed to `EuiProvider`: https://codesandbox.io/s/romantic-wilson-0oe88v?file=/index.js I think I know why as well, we essentially need to use option 3 in https://github.com/emotion-js/emotion/issues/1105#issuecomment-557726922 if...