eui icon indicating copy to clipboard operation
eui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Line 35 `isFunction` is missing in demo code.

Open 1a57danc3 opened this issue 2 years ago • 5 comments

https://elastic.github.io/eui/#/tabular-content/tables#build-a-custom-table-from-individual-components

Line 35 isFunction is missing, and code sandbox demo is broken.

1a57danc3 avatar Jun 08 '22 05:06 1a57danc3

services/predicate utils are not exported as part of the top level API, so we'll either need to change the how isFunction is imported in that file, update the codesandbox regex to account for this location, or not use the util in the demo.

code sandbox demo is broken

Can you explain this a bit more? There is no codesandbox link for that particular example. Did you build your own?

thompsongl avatar Jun 08 '22 14:06 thompsongl

@thompsongl You can click this link and try it.

image

1a57danc3 avatar Jun 08 '22 14:06 1a57danc3

🤦‍♂️ I looked in the wrong spot. Thanks for filing an issue!

thompsongl avatar Jun 08 '22 14:06 thompsongl

This could tie in / be fixed at the same time we remove our dependency on data_store as well 🤷 https://github.com/elastic/eui/issues/5837

cee-chen avatar Jun 08 '22 17:06 cee-chen

error I have found it and want to know that what is the solution of this issue .whether I have to check the component?

Himanxu1 avatar Jul 07 '22 11:07 Himanxu1

can i contribute on this issue?

OzairKhanBro avatar Nov 25 '22 11:11 OzairKhanBro

@OzairKhanBro feel free, this specific issue should be a basic typeof check. However, I don't know if the codesandbox demos will work even after the third-party util is fixed, until https://github.com/elastic/eui/issues/5837 as a whole is resolved.

cee-chen avatar Nov 28 '22 18:11 cee-chen