Cee Chen
Cee Chen
jenkins test this
Looks great! Feel free to hit merge on this! :tada:
Unfortunately, this isn't really enough information for us to help you with. 1. Can you create a [reproducible CodeSandbox](https://codesandbox.io/s/ocxfbg?file=/demo.js) of whatever issue you're running into? We need to see how...
This still seems valid.
CCing @daveyholler in on this once, since he was pairing/following along as I worked on some of these - figured he might be curious to see the end result :)
That's it for my review, I mostly just had minor syntax nits around the new JS. LMK if you'd rather me push up my change requests directly to the branch....
👋 Changes look great, Elizabet! After thinking it over, since these vars and utils are relatively complex and will be reused by other components, I'd like to write unit tests...
I don't think there's a super strong reason not to, but the reason why we haven't added that customization is that we expect Elastic apps to be using the Elastic...
Makes sense! I think Chandler's suggestion/approach of adding a more generic `iconProps` obj would cover your use case as well as add even more flexibility to the logo/icon. We'd definitely...
This looks and works great. I just have a couple very minor comments, fantastic work on this Trevor! edit to add: this is not a breaking change, just IMO, and...