Cedoor comments

Results 106 comments of


                                            Cedoor

Improve security practices

Thank you very much for pointing this out @sripwoud! Super important 🙏🏽

Improve security practices

@sripwoud We should give priority to this

Add check for the `message` parameter size in the EdDSA Poseidon library

Hi @hannahredler, of course! I'll assign it to you 👍🏽

Add check for the `message` parameter size in the EdDSA Poseidon library

Hi @hannahredler, are you still going to work on this?

Github workflows need to be revisited

@sripwoud looks like there are other issues with the workflows after this PR: https://github.com/semaphore-protocol/semaphore/pull/810. There are some warnings while building the libraries, and some untracked files are generated in the...

Github workflows need to be revisited

> which workflow/jobs exactly? There are quite a bunch ^^ Sorry, it's not directly related to the workflow. You can try yourself by just running `yarn build` after cloning the...

fix(eddsa-poseidon): Check size of the message parameter

> Hey @cedoor ah yes i just saw the other PR. Happy to adjust this PR as necessary once the other is finished. Great, thank you!

checking if newLeaf != this._nodes[0][index] first before update

Yes, it makes sense!

checking if newLeaf != this._nodes[0][index] first before update

@hannahredler sorry for the late reply. Do you still want to work on this?

Add CLI Foundry Template

Hi @jimmychu0807, be sure to create a branch from this PR, so that we can merge it here.