Cedoor

Results 106 comments of Cedoor

![](https://github.trello.services/images/mini-trello-icon.png) [Text on branches](https://trello.com/c/2OWxOcGv/3-text-on-branches)

![](https://github.trello.services/images/mini-trello-icon.png) [Branches size](https://trello.com/c/TVAfnitB/5-branches-size)

![](https://github.trello.services/images/mini-trello-icon.png) [Improve history](https://trello.com/c/mw3u7AYr/2-improve-history)

> @cedoor can I work on this issue? Hey @0xgun, sure you can! Make sure to read our [contributing](https://github.com/semaphore-protocol/semaphore/blob/main/CONTRIBUTING.md) file.

> @cedoor Should we mark this as completed? See #104 This is another task. That's the `insertMany` function. This would be the `updateMany`.

I took a closer look and it actually makes sense to leave it as it is. What we can do is re-use the BLAKE hash initially calculated for the public...

The only problem I see with passing the secret scalar is that the signMessage function needs the second part of the BLAKE hash too.

> I don't really understand the details of how the secret scalar is used in circuits It might not be super clear. It just means that it is recommended to...

> That's what I skimmed, and I see 3 different SHA-512 hashes. Even if blake is replacing that, it doesn't seem like our eddsa code is doing all the same...

@artwyman Reviewing this issue, I'm no longer sure it's worth disassembling `signMessage` to re-use the Blake hash. It doesn't seem as trivial as refactoring, and I don't know if the...