semaphore-protocol
Github workflows need to be revisited
Description
Semaphore's Github pull_requests workflow has recently been optimized to run some jobs only when related files are actually changed (https://github.com/semaphore-protocol/semaphore/pull/765). However, the file and folder paths to be considered for detecting changes do not take into account some configuration files, thus preventing some jobs from running even when they should.
Additionally, recently ZK-Kit has further optimized the workflows:
- merging the
pull_requestsandproductionworkflows into 1:main - sharing cached dependencies among jobs
Semaphore workflows therefore need to be updated with the above points in mind. This issue is supposed to be used to discuss these points and converge on a final solution to be adopted.
@sripwoud looks like there are other issues with the workflows after this PR: https://github.com/semaphore-protocol/semaphore/pull/810.
There are some warnings while building the libraries, and some untracked files are generated in the CLI templates.
which workflow/jobs exactly? There are quite a bunch ^^
Sorry, it's not directly related to the workflow. You can try yourself by just running yarn build after cloning the repo. It looks like the --topological-dev option doesn't work well.